-
Notifications
You must be signed in to change notification settings - Fork 407
[helm] Add a helm chart for Fluss #779 #1685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi, @dreger1997. If you have time. Can you rebase your branch to main? |
…svc for coordinator and headless svc for tablet
… tested with Flink inside the cluster
Done |
|
@dreger1997 Pls adding license header for your new introduce yaml files. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @dreger1997. Thanks for your great work. I have successfully launched Fluss in my local environment, but I feel the documentation is still insufficient. Can we provide an end-to-end guide that covers how to install it, what components are required, how to connect with Flink and create tables? Something similar to the following documentation: https://ricardo-aires.github.io/helm-charts/charts/kafka/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @dreger1997. Here are some minor suggestions.
|
Hi, @dreger1997 Could u change the helm-charts version to 0.8-SNAPSHOT. After that, I will merge this pr. |
…uild step in the README
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM +1
* First helm draft with statefulset tablet, coordinator, configmap and svc for coordinator and headless svc for tablet * fix coordinator selector * changed coordinator to headless svc and adapted advertised listeners, tested with Flink inside the cluster * fixed license headers, minor typo fixes and comment cleanup * fixed license for helpers.tpl * minor fix to use dynamic namespace naming in the config of advertised listeners * added docker.io as registry so people can use other images besides official one * added PVC and README to the helm chart * changed storageClass to null to use default * used helm templating to dynamically set the namespace in zookeeper address * changed versions from 0.7.0 to 0.8-SNAPSHOT and included the Docker build step in the README
Purpose
Linked issue: close #779
Creating a V1 Draft for Helm-charts with Apache Fluss and external Zookeeper
Brief change log
Tests
API and Format
Documentation
This is currently not working with CLIENTS external to the K8s Cluster